Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIL-B to fevm-contract-tests #63

Closed
wants to merge 3 commits into from

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented Aug 27, 2024

Why do you need this?

I want to assign FIL-B as a reviewer for filecoin-project/fevm-contract-tests#26

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@BigLep BigLep requested a review from rvagg August 27, 2024 14:57
@BigLep BigLep self-assigned this Aug 27, 2024
@BigLep BigLep marked this pull request as ready for review August 27, 2024 14:58
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User arajasek:
  - will lose push permission to fevm-contract-tests
User longfeiwan9:
  - will gain push permission to fevm-contract-tests
User maciejwitowski:
  - will lose push permission to fevm-contract-tests
User rk-rishikesh:
  - will gain push permission to fevm-contract-tests
User snissn:
  - will gain push permission to fevm-contract-tests
User trruckerfling:
  - will gain push permission to fevm-contract-tests
User xbalbinus:
  - will gain push permission to fevm-contract-tests
User xors-eng:
  - will gain push permission to fevm-contract-tests

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_repository_collaborator.this["fevm-contract-tests:arajasek"] will be destroyed
  # (because key ["fevm-contract-tests:arajasek"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "fevm-contract-tests:arajasek" -> null
      - permission = "push" -> null
      - repository = "fevm-contract-tests" -> null
      - username   = "arajasek" -> null
    }

  # github_repository_collaborator.this["fevm-contract-tests:maciejwitowski"] will be destroyed
  # (because key ["fevm-contract-tests:maciejwitowski"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "fevm-contract-tests:maciejwitowski" -> null
      - permission = "push" -> null
      - repository = "fevm-contract-tests" -> null
      - username   = "maciejwitowski" -> null
    }

  # github_team_repository.this["fil-b:fevm-contract-tests"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "fevm-contract-tests"
      + team_id    = "10353148"
    }

Plan: 1 to add, 0 to change, 2 to destroy.

@rvagg
Copy link
Member

rvagg commented Aug 28, 2024

done in #62, just did admin for lotus and fil-b

@rvagg rvagg closed this Aug 28, 2024
@rvagg rvagg deleted the biglep/add-fil-b-to-fevm-contract-tests branch August 28, 2024 01:27
@BigLep
Copy link
Member Author

BigLep commented Aug 28, 2024

Doh, thanks @rvagg . My bad for not seeing that this had already been done. Changes done as part of #61 to make githubm-mgmt-stewards not-private and to require approvals from codeowners will make it so notifications come through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants