Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add -Zfeatures=itarget to support conditional compilation of dependency feature based on target #163

Closed
wants to merge 1 commit into from

Conversation

dgbo
Copy link

@dgbo dgbo commented Jan 30, 2021

This is related to filecoin-project/rust-fil-proofs#1404.
We want to enable the feature compress, asm on aarch64 for sha2, while only enable feature compress on x86.
The -Zfeatures=itarget is necessary for supporting conditional compilation of dependency feature based on target [1][2].

[1] rust-lang/cargo#2524
[2] rust-lang/cargo#7914

@dgbo
Copy link
Author

dgbo commented Feb 3, 2021

With RustCrypto/hashes#224 merged into sha-0.9.3, this is not needed anymore.

@vmx
Copy link
Contributor

vmx commented Oct 30, 2023

I think this is fixed meanwhile, feel free to re-open if it's not.

@vmx vmx closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants