Delete deprecated UseBytes and RestoreBytes methods from verified registry #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## anorth/market-allocation #658 +/- ##
============================================================
+ Coverage 84.45% 84.60% +0.15%
============================================================
Files 95 95
Lines 19054 18989 -65
============================================================
- Hits 16092 16066 -26
+ Misses 2962 2923 -39
|
ZenGround0
approved these changes
Sep 15, 2022
| @@ -790,76 +786,4 @@ mod datacap { | |||
| } | |||
| h.check_state(&rt); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn restore() { | |||
There was a problem hiding this comment.
I have a feeling we'll want to reinstate these tests for verifreg::RemoveExpiredAllocations. A follow up is fine but in that case maybe leave these tests commented out so review is easier?
There was a problem hiding this comment.
I looked through and I think they'll be different enough to need basically re-writing. It's a good point to come check here for reference though.
There was a problem hiding this comment.
Looking through these now while finishing off testing:
- We use actor IDs for the client/provider, so no longer need to resolve addresses
- Anyone can call RemoveExpiredAllocations, not just the market actor
- No need to check minimums since we're dealing with allocation records the verifreg already has
anorth
force-pushed
the
anorth/verifreg-purge
branch
from
e35ffb8 to
4bd98ed
Compare
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting code is the best.
decouple-fil+after base PR is merged.