Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include datacap actor in build bundle #613

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

anorth
Copy link
Member

@anorth anorth commented Sep 7, 2022

I realised we need to add extra configuration to have a new builtin actor build for use in a network.

@Stebalien I'm more or less forced to use Datacap = 12 here because the build requires these to be sequential. When EVM merges into main some time after this, it'll have to take 13.

@anorth
Copy link
Member Author

anorth commented Sep 7, 2022

[Edit: worked after updating as expected]

This doesn't work yet, failing with

  thread 'main' panicked at 'failed to add file "/Users/me/plabs/filecoin-project/builtin-actors/target/debug/build/fil_builtin_actors_bundle-2b933924deb524f1/out/bundle/wasm32-unknown-unknown/wasm/fil_actor_datacap.wasm" to bundle for actor datacap: unrecognized actor type', build.rs:172:13

@Stebalien my first guess is that this will be resolved when we update to new FVM crates that have removed the FVM-side actor Type enum used by the bundler.

@anorth anorth requested a review from Stebalien September 7, 2022 07:55
@anorth anorth force-pushed the anorth/build-datacap branch from 6765e0d to e7842a1 Compare September 8, 2022 09:29
@anorth anorth marked this pull request as ready for review September 8, 2022 09:30
@anorth anorth changed the title WIP include datacap actor in build bundle Include datacap actor in build bundle Sep 8, 2022
@Stebalien
Copy link
Member

@Stebalien I'm more or less forced to use Datacap = 12 here because the build requires these to be sequential. When EVM merges into main some time after this, it'll have to take 13.

That's fine. We don't hard-code these anywhere anyways.

@Stebalien my first guess is that this will be resolved when we update to new FVM crates that have removed the FVM-side actor Type enum used by the bundler.

I assumed you fixed this by rebasing?

@anorth
Copy link
Member Author

anorth commented Sep 8, 2022

Yes worked after rebasing, ready for merge now

@anorth anorth merged commit b978d0d into decouple-fil+ Sep 8, 2022
@anorth anorth deleted the anorth/build-datacap branch September 8, 2022 22:45
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants