Implemented verified registry token receiver hook #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
force-pushed
the
anorth/verifreg-tokenreceiver
branch
4 times, most recently
from
505bd59 to
619312c
Compare
ZenGround0
reviewed
Sep 8, 2022
actors/verifreg/src/lib.rs
Outdated
| ) -> Result<AllocationRequests, ActorError> { | ||
| let reqs: AllocationRequests = deserialize(serialized, "allocation requests")?; | ||
|
|
||
| let mut allocation_total = StoragePower::zero(); |
There was a problem hiding this comment.
Why not DataCap? I think I'm missing something fundamental about how you use these types. If you use storage power here we should use it in claim_allocations too
There was a problem hiding this comment.
Ok changed, but I think we should delete the type now.
actors/verifreg/src/lib.rs
Outdated
| .id() | ||
| .unwrap(); | ||
| let code_cid = | ||
| rt.get_actor_code_cid(addr).with_context_code(ExitCode::USR_ILLEGAL_ARGUMENT, || { |
There was a problem hiding this comment.
If this was just a bad address wouldn't we already fail on resolve_address? If so this should be ILLEGAL_STATE.
There was a problem hiding this comment.
I see what you mean, but it's not this actor's state that is busted. Basically the runtime is returning nonsensical results. I'll leave it because I don't think ILLEGAL_STATE is better, though I agree this isn't perfect.
ZenGround0
approved these changes
Sep 8, 2022
anorth
force-pushed
the
anorth/verifreg-tokenreceiver
branch
from
619312c to
e02a793
Compare
anorth
force-pushed
the
anorth/verifreg-tokenreceiver
branch
from
e02a793 to
fc62f60
Compare
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the token receiver hook, which will replace UseBytes (when market updated in #527).
I deleted the UseBytes tests, replacing them with tests for the receiver hook.
Closes #525