Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 15.0.0-rc1 #1581

Merged
merged 8 commits into from
Oct 2, 2024
Merged

chore: release 15.0.0-rc1 #1581

merged 8 commits into from
Oct 2, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 1, 2024

Creating a builtin v15.0.0-rc1 release, following the process here: https://github.com/filecoin-project/builtin-actors/blob/master/RELEASE.md

chore: release 15.0.0-dev0
@rjan90 rjan90 self-assigned this Oct 1, 2024
chore: release 15.0.0-rc1
@rjan90 rjan90 changed the title chore: release 15.0.0-dev0 chore: release 15.0.0-rc1 Oct 1, 2024
@rvagg
Copy link
Member

rvagg commented Oct 2, 2024

I don't know why this is failing, I can't replicate the cargo error locally. @Stebalien do you have a clue about what might be going on here?

@rjan90
Copy link
Contributor Author

rjan90 commented Oct 2, 2024

I don't know why this is failing, I can't replicate the cargo error locally. @Stebalien do you have a clue about what might be going on here?

Think my PR was missing a cargo update, which I have now pushed, and the tests are now are passing. I´m wondering why the cargo.lock diff is so large though.

@rvagg
Copy link
Member

rvagg commented Oct 2, 2024

Oh, so I couldn't replicate it locally because I didn't pull in this branch with the version change.

So cargo update has updated your dependencies, which you probably don't want to do for this. If you just run cargo build it'll fix up the Cargo.lock with the new version. (There might also be some other command to do that that doesn't involve building too but I don't know what that is.)

chore: run `cargo build`
Copy link

github-actions bot commented Oct 2, 2024

Suggested version: 15.0.0-rc1

Comparing to: v14.0.0 (diff)

Changes in configuration file(s):

diff --git a/actors/miner/Cargo.toml b/actors/miner/Cargo.toml
index 047231f3..bc03e1ae 100644
--- a/actors/miner/Cargo.toml
+++ b/actors/miner/Cargo.toml
@@ -33,7 +33,6 @@ lazy_static = { workspace = true }
 log = { workspace = true }
 byteorder = { workspace = true }
 itertools = { workspace = true }
-const-hex = { workspace = true }
 
 [dev-dependencies]
 fil_actors_runtime = { workspace = true, features = ["test_utils", "sector-default"] }
@@ -43,6 +42,7 @@ fil_actor_power = { workspace = true }
 fil_actor_market = { workspace = true }
 rand = { workspace = true }
 test-case = { workspace = true }
+const-hex = { workspace = true }
 
 [features]
 fil-actor = ["fil_actors_runtime/fil-actor"]
diff --git a/actors/power/Cargo.toml b/actors/power/Cargo.toml
index c241b494..df67dcc9 100644
--- a/actors/power/Cargo.toml
+++ b/actors/power/Cargo.toml
@@ -33,6 +33,7 @@ fvm_ipld_encoding = { workspace = true }
 [dev-dependencies]
 fil_actors_runtime = { workspace = true, features = ["test_utils", "sector-default"] }
 fil_actor_reward = { workspace = true }
+const-hex = { workspace = true }
 
 [features]
 fil-actor = ["fil_actors_runtime/fil-actor"]
diff --git a/actors/verifreg/Cargo.toml b/actors/verifreg/Cargo.toml
index 66bd676b..2e003e5a 100644
--- a/actors/verifreg/Cargo.toml
+++ b/actors/verifreg/Cargo.toml
@@ -30,9 +30,9 @@ log = { workspace = true }
 num-derive = { workspace = true }
 num-traits = { workspace = true }
 serde = { workspace = true }
-const-hex = { workspace = true }
 
 [dev-dependencies]
+const-hex = { workspace = true }
 fil_actors_runtime = { workspace = true, features = ["test_utils", "sector-default"] }
 
 [features]
diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml
index 8056e463..3379ac93 100644
--- a/runtime/Cargo.toml
+++ b/runtime/Cargo.toml
@@ -55,6 +55,7 @@ optional = true
 derive_builder = { workspace = true }
 hex = { workspace = true }
 rand = { workspace = true }
+const-hex = { workspace = true }
 # Enable the test_utils feature when testing.
 fil_actors_runtime = { workspace = true, features = ["test_utils"] }
 

Cutting a Release (and modifying non-markdown files)

This PR is modifying both Cargo.toml and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's looking gooderer

@rjan90 rjan90 added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 831bf1b Oct 2, 2024
21 checks passed
@rjan90 rjan90 deleted the phi/prep-v15.0.0-rc1 branch October 2, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants