Explicit deal settlement in built-in market

[alexytsu]

#1313

Getting to this point has generated some new design decisions around state migration (which have been added to the google doc).

TODO:

• Fix existing market actor unit tests
• Fix existing integration tests
• Add tests for new activation flow and settlement flows (i.e. new activations that don't get scheduled for cron) Additional tests for synchronous termination and SettleDealPayments #1423
• Add tests for deals that are marked-for-termination but haven't been processed yet by cron
• Create tasks to track eventual deletion of unused tests and cron code for legacy deals
• Update params and return values to match FIP
• Change get_deal_activation to always fail if deal is terminated (regardless whether cleaned up)

[alexytsu]

@anorth ptal at the progress here. since you last reviewed I've made changes to switch to synchronous termination.

[alexytsu]

Marked non draft to run CI.

Still need to resolved TODOs in the description

[codecov-commenter]

Codecov Report

Merging #1377 (55a62dd) into integration/manual-settlement (2b1df06) will decrease coverage by 0.04%.
The diff coverage is 87.16%.

Additional details and impacted files

@@                        Coverage Diff                        @@
##           integration/manual-settlement    #1377      +/-   ##
=================================================================
- Coverage                          91.07%   91.04%   -0.04%     
=================================================================
  Files                                145      145              
  Lines                              27397    27595     +198     
=================================================================
+ Hits                               24951    25123     +172     
- Misses                              2446     2472      +26     

Files Changed	Coverage Δ
runtime/src/util/message_accumulator.rs	93.63% <0.00%> (-0.91%)	⬇️
actors/market/src/state.rs	91.93% <83.06%> (-1.47%)	⬇️
actors/market/src/testing.rs	94.94% <88.88%> (-1.13%)	⬇️
actors/market/src/lib.rs	93.70% <89.13%> (+1.82%)	⬆️
actors/market/src/types.rs	93.75% <100.00%> (+0.64%)	⬆️
integration_tests/src/expects.rs	95.76% <100.00%> (ø)
integration_tests/src/util/workflows.rs	99.35% <100.00%> (+0.01%)	⬆️

... and 2 files with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project).

[anorth]

I haven't reviewed the tests in full detail yet, but a few comments there. We'll certainly need tests for the new manual settlement. I think we should probably do that by converting most market tests to use manual settlement instead of cron. Then preserve or craft just a few test that insert legacy deals to test the transition behaviour.

[anorth]

Looking really good, thanks.

[alexytsu]

My apologies leaving this unmerged before I go on leave.

There's perhaps room for some more integration tests exercising the new method SettleDealPayments. Though most of the functionality is contained solely within the MarketActor and it's internal state, there is some interaction with the MinerActor regarding sector termination.

A set of integration tests should publish deals then test that different orderings of miner-initiated-sector-termination, activation(or failure to activate) and settle-deal-payments are accounted for correctly.

[anorth]

I have rebased this against a new integration branch, and will squash-merge to it. We can then continue to build on this with final tests and tweaks. @Kubuxu I would still appreciate your review of this post-merge, and we can apply changes in a follow-up.

[jennijuju]

@aarshkshah1992 @arajasek @Stebalien @Kubuxu - could you please provide a post-merge review to ensure correctness?

[anorth]

I will open a PR for integration into master and request review on that when I do.