-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds CommD as option in return value from ActivateDeals #1361
Conversation
395fb85
to
f7cbbd0
Compare
@ZenGround0 I think this is complete but I haven't evaluated testing yet. I'll confirm the existing integration tests cover this and would fail if the CommD was computed incorrectly, and perhaps add a quick market unit test. |
f7cbbd0
to
b67d97e
Compare
Tests upgraded to check CommD. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
- Coverage 90.74% 90.68% -0.06%
==========================================
Files 145 145
Lines 27354 27361 +7
==========================================
- Hits 24822 24813 -9
- Misses 2532 2548 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good, will attempt to look through tests in the next 24 hours.
|
||
use fil_actor_miner::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do these rearrangments come from? Is this some change in cargo fmt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up. It comes from my IDE's "Optimize Imports" function, which regroups imports into std, external crates, workspace crates, etc. Rustfmt by default doesn't care about import grouping, only alphabetical order within a group.
The group imports feature could be turned on, which would I think then completely specify the grouping and order (similar but slightly different to my IDE). After a one-time churn, this could reduce noise here in the future.
In the meantime I will attempt to avoid regrouping imports this way.
This avoids ProveReplicaUpdates calling the market twice consecutively.
Note this is based on
master
, it's not only part of direct data onboarding.Closes #1308