Add Batch Balancer parameter recalibration to FIP-0057 #673
Conversation
FIP-0057 changes the estimated gas usage for PreCommit and ProveCommit messages, which appear as parameters in the batch balancer mechanism. If parameters are not adjusting accordingly following these changes, this would change the batching thresholds, in terms of high enough base fee and large enough number of proofs in a batch. This change modifies FIP-0057 to include a corresponding update in the gas usage parameters of the Batch Balancer. A sentence is added in the **Abstract** section, and a subsection is added at the end of the **Specification** section
AxCortesCubero
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth and
raulk
as code owners
There was a problem hiding this comment.
The change makes sense, but I"m confused about how we're doing this -- FIP-0057 is already live in the network.
Is this PR a correction we're making to the text of FIP-0057 to reflect what already went live in nv18? Or a new change we're proposing making in nv19?
|
@arajasek it is an amendment/change to FIP0057 which the authors of this amendment are hoping to go live in nv19. Indeed a unique situation, but we agreed that the governance pathway would be to take this change through Last Call rather than have a new FIP as the proposed modification to maintain existing policy. I am not sure if this process makes sense from an implementation perspective. |
luckyparadise
added
the
Accepted
|
I'm going to strongly object to this change. Cryptoecon changes should not be after-the-fact amendments. Furthermore, this FIP was created to correct the gas model for nv18, while the issue fixed in this PR was addressing a change made in nv16. |
FIP-0057 changes the estimated gas usage for PreCommit and ProveCommit messages, which appear as parameters in the batch balancer mechanism. If parameters are not adjusting accordingly following these changes, this would change the batching thresholds, in terms of high enough base fee and large enough number of proofs in a batch.
This change modifies FIP-0057 to include a corresponding update in the gas usage parameters of the Batch Balancer.
A sentence is added in the Abstract section, and a subsection is added at the end of the Specification section