Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header padding for modal without footer #14645

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix header padding for modal without footer #14645

merged 1 commit into from
Oct 28, 2024

Conversation

zepfietje
Copy link
Member

Description

Modals with header but without footer would have no spacing below the header.
This PR fixes that.

Visual changes

Before

After

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@zepfietje zepfietje added bug Something isn't working ui labels Oct 28, 2024
@zepfietje zepfietje added this to the v3 milestone Oct 28, 2024
@danharrin danharrin merged commit 600908c into 3.x Oct 28, 2024
21 checks passed
@danharrin danharrin deleted the fix-header-padding-for-modal-without-footer branch October 28, 2024 08:53
danharrin added a commit that referenced this pull request Oct 28, 2024
@danharrin
Apply #14645
ed2a901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working ui
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@zepfietje @danharrin