Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conditional control over lazy-loading database notifications #14597

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

jackwh
Copy link
Contributor

@jackwh jackwh commented Oct 22, 2024

Description

Something of a followup to #13321 , this backwards-compatible PR simply adds a new option to control whether database notifications are lazy-loaded when enabled.

The rationale behind this is simply that it forces an extra server roundtrip on every page load, and for many apps, that's just unnecessary overhead.

Visual changes

N/A

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the enhancement New feature or request label Oct 23, 2024
@danharrin danharrin added this to the v3 milestone Oct 23, 2024
@danharrin danharrin merged commit 95da622 into filamentphp:3.x Oct 23, 2024
10 checks passed
@danharrin
Copy link
Member

Thanks

@jackwh jackwh deleted the patch-1 branch October 23, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants