Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added closure to distinct() #14515

Merged
merged 4 commits into from
Oct 16, 2024
Merged

added closure to distinct() #14515

merged 4 commits into from
Oct 16, 2024

Conversation

zaidpirwani
Copy link
Contributor

@zaidpirwani zaidpirwani commented Oct 12, 2024

Description

Adds closure functionality to the distinct method for form input components to dynamically control this validation / rule

Visual changes

No visual changes included in this PR.

Functional changes

  • Code style has been fixed by running the composer cs command. [note: composer cs gave timeout errors - my laptop isnt powerful enough, but it did modified my changes to match the style)
  • Changes have been tested to not break existing functionality.
  • [] Documentation is up-to-date. I dont think documentation needs to be updated as usually closures are not added documentation

@zaidpirwani zaidpirwani marked this pull request as ready for review October 12, 2024 17:28
@danharrin danharrin added the enhancement New feature or request label Oct 16, 2024
@danharrin danharrin added this to the v3 milestone Oct 16, 2024
@danharrin danharrin merged commit 8c73cd8 into filamentphp:3.x Oct 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants