Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display url when issue page can't be opened in browser #14401

Merged

Conversation

florianraith
Copy link
Contributor

Description

When executing artisan make:filament-issue without xdg-open or similar tools installed, there is no way to retrieve the generated URL. Instead, you receive an output like xdg-open: not found, which is not helpful. This issue can occur, for example, when developing in a Docker container where xdg-open is not installed (e.g. with sail).

This PR implements a simple error message when something goes wrong and additionally displays the generated link, allowing users to manually copy and paste the link into their browsers.

Visual changes

Before:
image

After:
image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@zepfietje zepfietje added the bug Something isn't working label Oct 1, 2024
@zepfietje zepfietje added this to the v3 milestone Oct 1, 2024
@danharrin danharrin merged commit d344166 into filamentphp:3.x Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants