fixes missing default validation messages on FileUpload #12928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered an unexpected behaviour in our running app after a composer update, so we investigated a little and found the origin in this PR: #12772
The addition of custom validation messages on a FileUpload has broken the default validation messages thrown in a failing rule.
Code Example:
Current Behaviour
On submit the error message shown says 'App\Rules\TestRule'
Expected Behaviour
On submit the error message shown says 'default validation message'
Functional changes
composer cs
command.