Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.X] Fix currency format #12763

Merged
merged 2 commits into from
May 13, 2024
Merged

[2.X] Fix currency format #12763

merged 2 commits into from
May 13, 2024

Conversation

billmn
Copy link
Contributor

@billmn billmn commented May 13, 2024

Description

This fix corrects the loading of the environment variable DEFAULT_CURRENCY when the config:cache command is used (https://laravel.com/docs/11.x/configuration#configuration-caching).

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label May 13, 2024
@danharrin danharrin added this to the v3 milestone May 13, 2024
@danharrin danharrin merged commit 995326f into filamentphp:2.x May 13, 2024
11 checks passed
@danharrin danharrin modified the milestones: v3, v2 May 13, 2024
@danharrin
Copy link
Member

Thanks

@billmn billmn deleted the fix-currency-format branch May 13, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
v2
Development

Successfully merging this pull request may close these issues.
2 participants
@billmn @danharrin