Use Testbench configuration feature #11595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
commented
Feb 27, 2024
| @@ -49,12 +51,7 @@ protected function getPackageProviders($app): array | |||
| ]; | |||
| } | |||
|
|
|||
| protected function defineDatabaseMigrations(): void | |||
| { | |||
| $this->loadMigrationsFrom(__DIR__ . '/../database/migrations'); | |||
There was a problem hiding this comment.
Using this causes Laravel to migrate the database twice, using RefreshDatabase trait (which starts a database transaction) and explicitly via loadMigrationsFrom().
Using testbench.yaml configurations only registers the paths to Migrator and runs the migration once via RefreshDatabase eliminating the issue introduced by caching PDO instances between tests: laravel/framework#47912
crynobone
commented
Feb 27, 2024
| - tests/database/migrations | ||
|
|
||
| workbench: | ||
| install: true |
There was a problem hiding this comment.
Having install: true and migrations other than false will migrate the default laravel migrations. Which means we no longer requires create_password_reset_tokens_table and create_users_table.
|
Very helpful, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Laravel 11 tests