aie.device to transaction ops as mlir pass #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportCreated: 2024-09-11 04:42Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
fifield
force-pushed
the
aie-to-config
branch
from
f92b1d9
to
b8dffbc
Compare
fifield
force-pushed
the
aiertx
branch
2 times, most recently
from
208ce00
to
3135638
Compare
Co-authored-by: Joseph Melber <[email protected]>
fifield
force-pushed
the
aie-to-config
branch
from
b8dffbc
to
d756aa1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+43
to
+44
| AIETranslateControlPacketsToUI32Vec(mlir::ModuleOp module, llvm::raw_ostream &output, | ||
| llvm::StringRef sequenceName = ""); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| AIETranslateControlPacketsToUI32Vec(mlir::ModuleOp module, llvm::raw_ostream &output, | |
| llvm::StringRef sequenceName = ""); | |
| AIETranslateControlPacketsToUI32Vec(mlir::ModuleOp module, | |
| llvm::raw_ostream &output, | |
| llvm::StringRef sequenceName = ""); |
| mlir::LogicalResult | ||
| AIETranslateControlPacketsToUI32Vec(mlir::ModuleOp, std::vector<uint32_t> &); | ||
| AIETranslateControlPacketsToUI32Vec(mlir::ModuleOp, std::vector<uint32_t> &, | ||
| llvm::StringRef sequenceName = ""); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| llvm::StringRef sequenceName = ""); | |
| llvm::StringRef sequenceName = ""); |
Comment on lines
+257
to
+260
| LogicalResult | ||
| xilinx::AIE::AIETranslateControlPacketsToUI32Vec(ModuleOp module, | ||
| std::vector<uint32_t> &instructions, | ||
| StringRef sequenceName) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| LogicalResult | |
| xilinx::AIE::AIETranslateControlPacketsToUI32Vec(ModuleOp module, | |
| std::vector<uint32_t> &instructions, | |
| StringRef sequenceName) { | |
| LogicalResult xilinx::AIE::AIETranslateControlPacketsToUI32Vec( | |
| ModuleOp module, std::vector<uint32_t> &instructions, | |
| StringRef sequenceName) { |
Comment on lines
300
to
+302
| LogicalResult | ||
| xilinx::AIE::AIETranslateControlPacketsToUI32Vec(ModuleOp module, | ||
| raw_ostream &output) { | ||
| xilinx::AIE::AIETranslateControlPacketsToUI32Vec(ModuleOp module, raw_ostream &output, | ||
| StringRef sequenceName) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| LogicalResult | |
| xilinx::AIE::AIETranslateControlPacketsToUI32Vec(ModuleOp module, | |
| raw_ostream &output) { | |
| xilinx::AIE::AIETranslateControlPacketsToUI32Vec(ModuleOp module, raw_ostream &output, | |
| StringRef sequenceName) { | |
| LogicalResult xilinx::AIE::AIETranslateControlPacketsToUI32Vec( | |
| ModuleOp module, raw_ostream &output, StringRef sequenceName) { |
| std::vector<uint32_t> instructions; | ||
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions); | ||
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions, sequenceName); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions, sequenceName); | |
| auto r = | |
| AIETranslateControlPacketsToUI32Vec(module, instructions, sequenceName); |
| }, | ||
| registerDialects); | ||
| TranslateFromMLIRRegistration registrationCtrlPkt( | ||
| "aie-ctrlpkt-to-bin", "Translate aiex.control_packet ops to binary", | ||
| [](ModuleOp module, raw_ostream &output) { | ||
| if (outputBinary == true) { | ||
| std::vector<uint32_t> instructions; | ||
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions); | ||
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions, sequenceName); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions, sequenceName); | |
| auto r = AIETranslateControlPacketsToUI32Vec(module, instructions, | |
| sequenceName); |
Comment on lines
+188
to
+190
| static LogicalResult | ||
| generateTxn(AIERTControl &ctl, const StringRef workDirPath, DeviceOp &targetOp, | ||
| bool aieSim, bool enableElfs, bool enableInit, bool enableCores) { |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| static LogicalResult | |
| generateTxn(AIERTControl &ctl, const StringRef workDirPath, DeviceOp &targetOp, | |
| bool aieSim, bool enableElfs, bool enableInit, bool enableCores) { | |
| static LogicalResult generateTxn(AIERTControl &ctl, const StringRef workDirPath, | |
| DeviceOp &targetOp, bool aieSim, | |
| bool enableElfs, bool enableInit, | |
| bool enableCores) { |
Comment on lines
+226
to
+227
| auto result = | ||
| generateTxn(ctl, clElfDir, device, aieSim, true, true, true); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| auto result = | |
| generateTxn(ctl, clElfDir, device, aieSim, true, true, true); | |
| auto result = generateTxn(ctl, clElfDir, device, aieSim, true, true, true); |
fifield
force-pushed
the
aie-to-config
branch
from
29661c8
to
f3b5221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.