Skip to content

Commit

Permalink
Disable Default XYZ Precision and Default E Precision
Browse files Browse the repository at this point in the history
These arguments are currently broken in ArcWelderLib. See FormerLurker/ArcWelderLib#72
  • Loading branch information
fieldOfView committed Jul 16, 2021
1 parent b452ad5 commit 8a2c1aa
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 17 deletions.
6 changes: 3 additions & 3 deletions ArcWelderPlugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ def _filterGcode(self, output_device):
self._arcwelder_path,
"-m=%f" % maximum_radius,
"-t=%f" % path_tolerance,
"-r=%f" % resolution,
"-x=%d" % default_xyz_precision,
"-e=%d" % default_e_precision,
"-r=%f" % resolution
#"-x=%d" % default_xyz_precision,
#"-e=%d" % default_e_precision,
]

if firmware_compensation:
Expand Down
12 changes: 1 addition & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This plugin wraps [ArcWelderLib](https://github.com/FormerLurker/ArcWelderLib) b

Inspired by on a postprocessing script by [yysh12](https://github.com/yysh12)

For further informations about ArcWelder antistutter, see https://plugins.octoprint.org/plugins/arc_welder
For further information about ArcWelder antistutter, see https://plugins.octoprint.org/plugins/arc_welder

## Arcwelder Settings

Expand Down Expand Up @@ -39,16 +39,6 @@ Not all gcode has the same precision for X, Y, and Z parameters. Enabling this

**Important Note**: This option used to be the default, but in some cases I've seen files with unusually high precision. If it gets too high, the resulting gcode may overrun the gcode buffer size, causing prints to fail. For that reason, this option has been disabled by default. I've only seen a few cases where this happens, and it's always been due to custom start/end gcode with extremely high precision.

### Default XYZ Precision
ArcWelder outputs fixed precision for X, Y, Z, I, and J parameters. 99% of the time the default of 3 decimal places is just fine. If you need (want) more or less precision, you can alter this value. In general, I do not recommend a value below 3 or above 5.

Note that when combined with the 'Allow Dynamic Precision' setting, this represents the minimum precision. It will grow if Arc Welder encounters gcode commands with a higher precision.

### Default E Precision
Arc Welder outputs fixed precision for the E parameter (extruder travel). 99% of the time the default of 5 decimal places is what you want. If you need (want) more or less precision, you can alter this value. In general, I do not recommend a value below 3 or above 5.

Note, that when combined with the 'Allow Dynamic Precision' setting, this represents the minimum precision. It will grow if Arc Welder encounters gcode commands with a higher precision.

### Firmware Compensation
**Important**: Do **NOT** enable firmware compensation unless you are sure you need it! Print quality and compression will suffer if it is enabled needlessly.

Expand Down
6 changes: 3 additions & 3 deletions arcwelder_settings.def.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,21 @@
"settable_per_mesh": false,
"settable_per_extruder": false,
"settable_per_meshgroup": false,
"enabled": "arcwelder_enable"
"enabled": "arcwelder_enable and False"
},
"arcwelder_default_e_precision":
{
"label": "Default E Precision",
"description": "The number of decimal places of coordinates of arc segments in the E axis. When combined with the 'Allow Dynamic Precision' setting, this represents the minimum precision.",
"type": "int",
"default_value": 3,
"default_value": 5,
"minimum_value": 0,
"minimum_value_warning": 2,
"maximum_value_warning": 6,
"settable_per_mesh": false,
"settable_per_extruder": false,
"settable_per_meshgroup": false,
"enabled": "arcwelder_enable"
"enabled": "arcwelder_enable and False"
},
"arcwelder_firmware_compensation":
{
Expand Down

0 comments on commit 8a2c1aa

Please sign in to comment.