Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to install FastAPI Fief client through conda-forge #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@frankie567
Copy link
Member

Thank you @davidbrochart! So... Does it mean there is a feedstock for the client on Conda Forge? Sorry if it's a dumb question, I'm really not aware of how Conda works 😄

@davidbrochart
Copy link
Contributor Author

Does it mean there is a feedstock for the client on Conda Forge?

Yes! https://github.com/conda-forge/fief-client-fastapi-feedstock

@frankie567
Copy link
Member

That's great! I see it's packaged with the optional FastAPI dependencies; is there something similar in Conda that would let us, just like pip, to have a "base package" and have optional dependencies for FastAPI/Flask/etc?

@davidbrochart
Copy link
Contributor Author

No, that's really specific to pip.
The conda-forge package is fief-client-fastapi, hopefully it's clear that it has the FastAPI dependency.
Other options would be to:

  • create a package fief-client that has all optional dependencies (FastAPI, Flask...), but the user could end up with dependencies that they don't need.
  • create a package fief-client with no optional dependency, and let the user install them, e.g. mamba install fief-client fastapi.
  • create a feedstock fief-client with multiple outputs corresponding to each package variant.

@frankie567
Copy link
Member

Hmm... I see 🤔

  • create a feedstock fief-client with multiple outputs corresponding to each package variant.

Is that difficult to do? Is it possible to do that on the existing feedstock and rename it?

@davidbrochart
Copy link
Contributor Author

@wolfv doesn't like multiple outputs, IIRC 😄

@frankie567
Copy link
Member

Ha 😬 Well, since I've zero experience with Conda, I'll trust you to take the best decision.

It's just that if one day someone comes and asks to have the fief-client-flask package and we have to create a whole feedstock from scratch, it looks a bit tedious to me 😅

@davidbrochart
Copy link
Contributor Author

But you're right, it would make more sense. I'll see if I can create a multiple-output feedstock.

@davidbrochart
Copy link
Contributor Author

I'm trying there, but it doesn't work yet: conda-forge/staged-recipes#20279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants