Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing composer.sh, ref #491 #492

Merged
merged 2 commits into from
Sep 2, 2015
Merged

Fixing composer.sh, ref #491 #492

merged 2 commits into from
Sep 2, 2015

Conversation

stefantalen
Copy link
Contributor

Altering the arguments so they are being processed correctly.

My knowledge of bash scripts isn't that great, but using these changes fixed the issue I had (#491)

@fideloper
Copy link
Owner

howdy!

I'm not sure using sudo would be a real fix here, in theory installing packages globally can/should still be per user (well, that seems to be a matter of opinion).

I think we can make use of the COMPOSER_HOME environment variable, explicitly, in this installer script as an alternative. Example: https://coderwall.com/p/ma_cuq/using-composer-to-manage-global-packages

@stefantalen
Copy link
Contributor Author

Updated the pull request, I've ran vagrant provision multiple times and still haven't had any errors so I guess it is save to use.

@fideloper
Copy link
Owner

Cool, let's try that out -thanks for giving it some tests as well :D

fideloper added a commit that referenced this pull request Sep 2, 2015
@fideloper fideloper merged commit 2ac6256 into fideloper:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants