Fixed the NVM Installer

[mohitmamoria]

The NVM installer was using 'echo' statement when echoing the string with '\n' in it. 'echo' statement doesn't work with '\n' and thus we have to use printf command. The official installer does use 'printf' itself (link to official).

This pull request fixes the issue.

[Ilyes512]

Either printf or echo -e will do 👍

[fideloper]

this is good to merge, right @Ilyes512. I think you said you had some fixes to do?

[Ilyes512]

I handt had a chance to fix it yet. The node installer doesn't work at the moment, right? Cause of the version "grepping". I will be having a look at it today, but probably tomorrow.

[fideloper]

Yea, that's the issue so far as know. I think the fix is as simple as this:

Changing this line to this seemed to work for me in bash:

curl 'nodejs.org' | grep 'Current Version' | awk '{ print $4 }' | awk -F\< '{ print $1 }'

Where in I print $4 rather than print $3. Also grabs the string with the v in it.

(That's referencing Vaprobash12 Issue 3)

[Ilyes512]

If you tested it and it works ^^ So the version prefixed with v is no problem?

[fideloper]

I only did the curl request adjustment, haven't tested full nvm install.

Not sure about the v, I imagine it would be an issue.

On Tuesday, August 12, 2014, Ilyes [email protected] wrote:

If you tested it and it works ^^ So the version prefixed with v is no
problem?

—
Reply to this email directly or view it on GitHub
#361 (comment).

[mohitmamoria]

It works fine. I am using it to provision my production servers, and they
were provisioned nicely. :)

• Mohit :)

On Tue, Aug 12, 2014 at 4:35 PM, Chris Fidao [email protected]
wrote:

I only did the curl request adjustment, haven't tested full nvm install.

Not sure about the v, I imagine it would be an issue.

On Tuesday, August 12, 2014, Ilyes [email protected] wrote:

If you tested it and it works ^^ So the version prefixed with v is no
problem?

—
Reply to this email directly or view it on GitHub
#361 (comment).

—
Reply to this email directly or view it on GitHub
#361 (comment).

[fideloper]

I updated the curl request to get $4, which grabs the version with the "v". I believe that's correct as the distributions have the "v" in the filename, so we should be good to go now 👍