-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update win32 test serializer to work on any win32 machine #313
test: update win32 test serializer to work on any win32 machine #313
Conversation
|
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
99e2a3d
to
d88ec57
Compare
if you want we could just replace jest-serializer-path with simpler serializer |
If we could makes it work with a simple, promising script, we definitely could remove jest-serializer-path. |
do you want me to update this PR, or submit it as separate one? |
updating this PR is fine. |
…ith simpler serializer
Looks like something like this is going to work |
Thank you! I'm AFK now, will take a look into the code when back later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This Pr fixes snapshot testing on windows machines that are not CI
ideally we would want to fix this issue upstream in
jest-serializer-path
, but this repo seem to be no longer maintained#327 (comment)