Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import name conflicts with pysclint pyhdf package #13

Closed
fhs opened this issue Mar 21, 2018 · 15 comments
Closed

import name conflicts with pysclint pyhdf package #13

fhs opened this issue Mar 21, 2018 · 15 comments

Comments

@fhs
Copy link
Owner

fhs commented Mar 21, 2018

I was hoping to eventually have changes in this repo be merge into pysclint pyhdf, but that seems unlikely since pysclint appears to be unmaintained -- the last commit was in 2008.

I think it's time this package had it's own name. It would be less confusing and allow users to install this package along with pysclint pyhdf in the same python installation. Some import names I'm considering:

  • hdf4py
  • h4py (similar to h5py)
  • hdf4
@djhoese
Copy link

djhoese commented May 8, 2018

@fhs I ran in to a recent issue related to this and started doing some research. It looks like the HDF-EOS group has kept up development a little bit: http://hdfeos.org/software/pyhdf.php.

This is actually the release that conda-forge is using to make their conda package: https://github.com/conda-forge/pyhdf-feedstock/blob/master/recipe/meta.yaml

I'm not sure what changes were made to this package, but maybe they could be merged with the HDF-EOS groups changes and someone could update the PyPI package.

@fhs
Copy link
Owner Author

fhs commented May 8, 2018

I think they are using a fork of this repo (https://github.com/hdfeos/pyhdf), which has not diverged much. Although I think it's missing a bug fix that I recently pushed out.

It looks like they are sticking to "pyhdf" package name, so maybe we should stay with that name. The only issue I have with that is pip install pyhdf installs the old pysclint pyhdf. You need to run pip install python-hdf4 to install the new one, which is confusing.

@djhoese
Copy link

djhoese commented May 8, 2018

Agreed that it is confusing. You or HDF-EOS should probably contact the maintainers of the PyPI package and ask for permission to take of the project on PyPI (I've done this for other projects that became unmaintained). It would be best if the pyhdf that users got from PyPI was the same as from conda-forge.

In fact, the issue I was having is that my test_requires in my setup.py was checking for python-hdf4 but in a conda environment it is called pyhdf (from conda-forge) so it tried to install the python-hdf4 package even though pyhdf was already installed.

@fhs
Copy link
Owner Author

fhs commented May 9, 2018

@hdfeos any opinion? I'd like to see hdfeos take over maintenance of this package if possible. I'll of course help out as much as I can.

@djhoese
Copy link

djhoese commented May 10, 2018

@fhs I suppose you could always make a pull request on their fork to make it up to date.

It's too bad that things like this happen without maintainers notifying each other.

@hdfeos
Copy link
Contributor

hdfeos commented May 14, 2018

@fhs, h4py sounds best for community but we are not going to maintain it because we don't have resources.

@djhoese
Copy link

djhoese commented May 14, 2018

@hdfeos Seeing as the HDF-EOS groups package is being used by conda-forge would it be possible to give @fhs maintainer permissions of the repository (that was based on this repository) and then they/we can work on updating the pyhdf PyPI package?

I personally think that making a new package name is not the right solution for this project. "pyhdf" is known by the community and making a new one is going to take time to synchronize across the fields that need it.

@hdfeos
Copy link
Contributor

hdfeos commented May 14, 2018

@djhoese I added @fhs and @djhoese as collaborator on my fork.

@djhoese
Copy link

djhoese commented May 14, 2018

@fhs You can find the email address for the author of pyhdf on the PyPI page if you'd be willing to get PyPI access to the project so you can start releasing the HDF-EOS version as "pyhdf" on PyPI: https://pypi.org/project/pyhdf/

@fhs
Copy link
Owner Author

fhs commented Jun 8, 2018

I reached out to the original author (Andre Gosselin) about a week ago but haven't received any response. I think @teoliphant has access to pyhdf on PyPI, but I'm not sure if he's an Owner or a Maintainer.

There are two possible roles for collaborators:

Maintainer
Can upload releases for a package. Cannot add collaborators. Cannot delete files, releases, or the project.
Owner
Can upload releases. Can add other collaborators. Can delete files, releases, or the entire project.

@djhoese
Copy link

djhoese commented Jun 8, 2018

You could try making an issue on the issue tracker: https://github.com/pypa/warehouse/issues

Or wait for the work discussed here: https://pypi.org/help/#project-name-claim

@djhoese
Copy link

djhoese commented Nov 7, 2018

@fhs is there any update on this?

@fhs
Copy link
Owner Author

fhs commented Nov 7, 2018

@djhoese No update, unfortunately. I guess we should open an issue in pypa/warehouse?

@djhoese
Copy link

djhoese commented Dec 4, 2018

See pypi/warehouse#5157 for the status of this ownership transfer. I think our wires got crossed @fhs. I thought you were going to make the issue.

@fhs
Copy link
Owner Author

fhs commented Dec 4, 2018

Thanks for opening the issue @djhoese

fhs added a commit that referenced this issue Mar 8, 2019
fhs added a commit that referenced this issue Mar 8, 2019
@fhs fhs closed this as completed in #22 Mar 9, 2019
fhs added a commit that referenced this issue Mar 9, 2019
* Change package name from python-hdf4 to pyhdf

Fixes #13

* Rename python-hdf4 to pyhdf everywhere

* Update README

* Convert README to markdown

* Update copyright year in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants