Prevents cli from throwing unexpected error when podman endpoint is n…

…o longer available Fixes skupperproject#1219.
fgiorgetti · Nov 3, 2023 · c22cbe0 · c22cbe0
1 parent 0b78808
commit c22cbe0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/client/podman/rest.go b/client/podman/rest.go
@@ -42,7 +42,7 @@ func NewPodmanClient(endpoint, basePath string) (*PodmanRestClient, error) {
 	var err error
 
 	if endpoint == "" {
-		defaultEndpoint := fmt.Sprintf("unix://%s/podman/podman.sock", config.GetRuntimeDir())
+		defaultEndpoint := GetDefaultPodmanEndpoint()
 		endpoint = utils.DefaultStr(os.Getenv(ENV_PODMAN_ENDPOINT), defaultEndpoint)
 	}
 
@@ -143,6 +143,10 @@ func NewPodmanClient(endpoint, basePath string) (*PodmanRestClient, error) {
 	return cli, nil
 }
 
+func GetDefaultPodmanEndpoint() string {
+	return fmt.Sprintf("unix://%s/podman/podman.sock", config.GetRuntimeDir())
+}
+
 func (p *PodmanRestClient) IsSockEndpoint() bool {
 	return strings.HasPrefix(p.endpoint, "/") || strings.HasPrefix(p.endpoint, "unix://")
 }

diff --git a/cmd/skupper/skupper_podman.go b/cmd/skupper/skupper_podman.go
@@ -7,6 +7,7 @@ import (
 	"github.com/skupperproject/skupper/api/types"
 	clientpodman "github.com/skupperproject/skupper/client/podman"
 	"github.com/skupperproject/skupper/pkg/domain/podman"
+	"github.com/skupperproject/skupper/test/utils"
 	"github.com/spf13/cobra"
 )
 
@@ -83,13 +84,16 @@ func (s *SkupperPodman) NewClient(cmd *cobra.Command, args []string) {
 	// endpoint can be provided during init
 	var endpoint string
 	var isInitCmd bool
+	exitOnError := true
 	switch cmd.Name() {
 	case "init":
 		// require site not present
 		if len(args) == 1 {
 			endpoint = args[0]
 		}
 		isInitCmd = true
+	case "version":
+		exitOnError = false
 	default:
 		podmanCfg, err := podman.NewPodmanConfigFileHandler().GetConfig()
 		if err != nil {
@@ -101,8 +105,9 @@ func (s *SkupperPodman) NewClient(cmd *cobra.Command, args []string) {
 
 	c, err := clientpodman.NewPodmanClient(endpoint, "")
 	if err != nil {
-		if endpoint != "" {
-			fmt.Printf("Podman endpoint is not available: %s", endpoint)
+		if exitOnError {
+			fmt.Printf("Podman endpoint is not available: %s",
+				utils.StrDefault(endpoint, clientpodman.GetDefaultPodmanEndpoint()))
 			fmt.Println()
 			os.Exit(1)
 		}

diff --git a/cmd/skupper/skupper_podman_site.go b/cmd/skupper/skupper_podman_site.go
@@ -293,7 +293,9 @@ func (s *SkupperPodmanSite) UpdateFlags(cmd *cobra.Command) {
 func (s *SkupperPodmanSite) Version(cmd *cobra.Command, args []string) error {
 	site := s.podman.currentSite
 	if site == nil {
-		return fmt.Errorf("Skupper is not enabled for user '%s'", podman.Username)
+		fmt.Printf("Skupper is not enabled for user '%s'", podman.Username)
+		fmt.Println()
+		return nil
 	}
 	for _, deploy := range site.GetDeployments() {
 		for _, component := range deploy.GetComponents() {