Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #86

Closed
drahnr opened this issue Mar 9, 2020 · 6 comments
Closed

Improve CI #86

drahnr opened this issue Mar 9, 2020 · 6 comments
Assignees

Comments

@drahnr
Copy link
Member

drahnr commented Mar 9, 2020

Currently execution is only done on native, but this shall not limit test compilation for cudnn.

cargo b --tests

for all feature sets

should suffice to catch most if not all issues with compilation.

Runtime errors are hard to catch, since native execution with running GPUs is hard to achieve with concourse, and there is nothing else out there that one can host yourself with the same feature set.

@drahnr
Copy link
Member Author

drahnr commented Mar 9, 2020

Related to #24

@drahnr
Copy link
Member Author

drahnr commented Mar 9, 2020

Also note the issue that cargo does not handle feature flags with workspaces just yet, which makes that rather tedious to implement in CI right now.

@drahnr drahnr self-assigned this Mar 9, 2020
@drahnr
Copy link
Member Author

drahnr commented Mar 10, 2020

Also note the issue that cargo does not handle feature flags with workspaces just yet, which makes that rather tedious to implement in CI right now.

The related cargo issue: rust-lang/cargo#5015

@drahnr
Copy link
Member Author

drahnr commented Mar 10, 2020

@drahnr
Copy link
Member Author

drahnr commented Mar 13, 2020

From: https://concourse-ci.org/concourse-worker.html#configuring-gdn-server

/usr/local/concourse/bin/gdn server --help

shows --runtime-plugin= which defaults to runc :) so plugging in nvidia-container-runtime should do the trick 🤞
If not, setting a prestart hook on the default shipped runc should work too via --runtime-plugin-extra-arg= 🤞

@drahnr drahnr pinned this issue Mar 13, 2020
@drahnr
Copy link
Member Author

drahnr commented Mar 23, 2020

CI is now working, the setup complexity got a little more intricate than anticipated, but it works now (and showed that we might need to regenerated the cudnn-sys with bindgen, see https://ci.spearow.io/teams/spearow/pipelines/juice/jobs/pr-test-juice/builds/114)

@drahnr drahnr closed this as completed Mar 23, 2020
@drahnr drahnr unpinned this issue Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant