Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt juice and coaster #24

Closed
crackcomm opened this issue Nov 6, 2017 · 7 comments
Closed

rustfmt juice and coaster #24

crackcomm opened this issue Nov 6, 2017 · 7 comments

Comments

@crackcomm
Copy link

I can provide pull request but you might want to do it yourself so you don't have to review it.

Code base would be much cleaner, easier to read, thank you.

@drahnr
Copy link
Member

drahnr commented Nov 6, 2017

What exactly are you suggesting? cargo fmt run? I tried to avoid it due to a huge changeset just for formatting, but I am with you, that it has to happen.

@crackcomm
Copy link
Author

Yes, I would also suggest creating CI rules to check for formatting.

@drahnr
Copy link
Member

drahnr commented Nov 7, 2017

That is mostly a task for the mergebot that deals with this as a post merge step and then ammends into the merge commit.

Not sure about individual commits, but I guess that would be an option too to just do the same on a per commit basis.

@drahnr
Copy link
Member

drahnr commented Nov 7, 2017

Another thing to consider is, that certain macros are really hard to read with default formatting with forced lin breaks, so the first step would be to figure out a config that does not change too much of the currrent style. I am mostly looking at max-line-lnegth (or however that parameter is called).

@drahnr
Copy link
Member

drahnr commented Nov 28, 2017

@crackcomm I'd be happy to review + test PRs

@andreytkachenko
Copy link
Contributor

Ok, what the resolution, we creating linters or submitting PRs with cargo fmt I would prefer both?

@drahnr
Copy link
Member

drahnr commented Jun 18, 2019

Both, CI ist mostly dormant now and it's pipes suffered a bit from bitrot, that's my next TODO

@drahnr drahnr mentioned this issue Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants