Skip to content

Commit

Permalink
sh_eth: propagate platform_get_irq() error upstream
Browse files Browse the repository at this point in the history
The driver overrides the error returned by platform_get_irq() with -ENODEV
which e.g. precludes the deferred  probing from working. Propagate the real
error code to the driver core instead.

Signed-off-by: Sergei Shtylyov <[email protected]>
Acked-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Sergei Shtylyov authored and davem330 committed Aug 29, 2015
1 parent f375339 commit 7a468ac
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/ethernet/renesas/sh_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -3089,10 +3089,8 @@ static int sh_eth_drv_probe(struct platform_device *pdev)

ndev->dma = -1;
ret = platform_get_irq(pdev, 0);
if (ret < 0) {
ret = -ENODEV;
if (ret < 0)
goto out_release;
}
ndev->irq = ret;

SET_NETDEV_DEV(ndev, &pdev->dev);
Expand Down

0 comments on commit 7a468ac

Please sign in to comment.