Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to OTel PR for latest design #4

Merged
merged 17 commits into from
Jan 31, 2024
Merged

feat: update to OTel PR for latest design #4

merged 17 commits into from
Jan 31, 2024

Conversation

feywind
Copy link
Owner

@feywind feywind commented Nov 29, 2023

Separated out for CR.

@feywind feywind changed the title Update to OTel PR for latest design feat: update to OTel PR for latest design Nov 30, 2023
Copy link

@alevenberg alevenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some initial comments.

src/telemetry-tracing.ts Outdated Show resolved Hide resolved
src/telemetry-tracing.ts Outdated Show resolved Hide resolved
src/telemetry-tracing.ts Outdated Show resolved Hide resolved
src/telemetry-tracing.ts Show resolved Hide resolved
src/subscriber.ts Show resolved Hide resolved
@feywind
Copy link
Owner Author

feywind commented Jan 31, 2024

Merging this back into the main OTel PR.

@feywind feywind merged commit be5fa9c into otel-4 Jan 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants