forked from googleapis/nodejs-pubsub
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up the "hello world" code sample (googleapis#328)
Changes to code: + Add region tags for including code in docs + Change `require()` call for consistency with the API docs; the sample now requires the library as `Bigtable` and creates an instance of it by calling `new Bigtable()` + Add comments about shortcuts that would cause performance issues in production + Fix misspelled variable Changes to `README`: + Fix branding issues + Update auth instructions to use the current best practice; `gcloud auth application-default login` is no longer recommended + Update links to the GCP Console + Remove embedded screenshot from the docs, to prevent a broken image if that screenshot goes away + Miscellaneous changes for clarity and consistency
- Loading branch information
Showing
3 changed files
with
81 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ Alexander Fenster <[email protected]> | |
Dave Gramlich <[email protected]> | ||
Eric Uldall <[email protected]> | ||
Jason Dobry <[email protected]> | ||
Jeff Williams <[email protected]> | ||
Jiren Patel <[email protected]> | ||
Jun Mukai <[email protected]> | ||
Luke Sneeringer <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters