Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added styling #924

Merged
merged 1 commit into from
Nov 26, 2024
Merged

added styling #924

merged 1 commit into from
Nov 26, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR fixes #919 by implementing the fixes described in executablebooks/sphinx-book-theme#879

Thanks @dylanh724 for the fixes!

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link
Collaborator

@KulaginVladimir KulaginVladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix works 👍

@KulaginVladimir
Copy link
Collaborator

@RemDelaporteMathurin
Just noticed (maybe unnecessary), but is it possible to reduce this space?
Снимок экрана 2024-11-26 225852

@RemDelaporteMathurin
Copy link
Collaborator Author

@RemDelaporteMathurin Just noticed (maybe unnecessary), but is it possible to reduce this space? Снимок экрана 2024-11-26 225852

I don't know how to do this but maybe we can tweak the css styling ... I'm not a web dev so this is all dark magic to me. Maybe @dylanh724 knows?

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (a82f0d2) to head (bc4ebdf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          60       60           
  Lines        2717     2717           
=======================================
  Hits         2705     2705           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit d5bb806 into main Nov 26, 2024
8 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the fix-icons branch November 26, 2024 22:00
@dylanh724
Copy link

dylanh724 commented Nov 27, 2024

@RemDelaporteMathurin Just noticed (maybe unnecessary), but is it possible to reduce this space?

I'm out of time to inspect further (since it's beyond the scope of the bugs), but Press F12 and inspect the parent box wrapping them. Play with the numbers near the top until it's desired, then override it with css. You're probably looking for margins or padding keywords. If the outer box doesnt work, try targeting the icons themselves - maybe its a rule on them rather than the parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons in documentation top bar are stacked
3 participants