Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive timestepping #916

Merged

Conversation

kaelyndunnell
Copy link
Contributor

@kaelyndunnell kaelyndunnell commented Nov 5, 2024

Proposed changes

Adds new features (milestones, maximum stepsize) to adaptive timestepping in fenicsx in line with Issues #913 and #912.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@kaelyndunnell kaelyndunnell marked this pull request as draft November 5, 2024 21:05
@kaelyndunnell kaelyndunnell changed the base branch from main to fenicsx November 5, 2024 21:05
@RemDelaporteMathurin RemDelaporteMathurin marked this pull request as ready for review November 5, 2024 21:07
@kaelyndunnell kaelyndunnell marked this pull request as draft November 5, 2024 21:07
@kaelyndunnell kaelyndunnell marked this pull request as ready for review November 5, 2024 21:07
This was linked to issues Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (7a770bc) to head (6b68b91).
Report is 39 commits behind head on fenicsx.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #916      +/-   ##
===========================================
+ Coverage    97.76%   97.80%   +0.04%     
===========================================
  Files           44       44              
  Lines         2099     2142      +43     
===========================================
+ Hits          2052     2095      +43     
  Misses          47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaelyndunnell that's super needed! 🚀

I think there is an edge case that you haven't tested (see comments below).

Also needs tests for milestones.

src/festim/stepsize.py Outdated Show resolved Hide resolved
src/festim/stepsize.py Outdated Show resolved Hide resolved
src/festim/stepsize.py Outdated Show resolved Hide resolved
src/festim/stepsize.py Show resolved Hide resolved
src/festim/stepsize.py Outdated Show resolved Hide resolved
test/test_stepsize.py Outdated Show resolved Hide resolved
kaelyndunnell and others added 3 commits November 5, 2024 16:28
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
test/test_stepsize.py Outdated Show resolved Hide resolved
test/test_stepsize.py Outdated Show resolved Hide resolved
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
@RemDelaporteMathurin RemDelaporteMathurin added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Nov 5, 2024
@RemDelaporteMathurin RemDelaporteMathurin merged commit 8c5a965 into festim-dev:fenicsx Nov 6, 2024
8 checks passed
@kaelyndunnell kaelyndunnell deleted the adaptive-timestepping branch November 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestones for simulation Implement stepsize cap
2 participants