Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of maintainers in docs #815

Merged
merged 1 commit into from
Jul 23, 2024
Merged

List of maintainers in docs #815

merged 1 commit into from
Jul 23, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Fixes #803

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (84e7861) to head (c3f54fc).
Report is 111 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #815   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          61       61           
  Lines        2707     2707           
=======================================
  Hits         2695     2695           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The maintainers are the people who have the right to merge PRs to the repository.
They consist of the following individuals:

- Remi Delaporte-Mathurin (`@RemDelaporteMathurin <https://github.com/RemDelaporteMathurin>`_)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fine to me, but don't you want to add your degree here, i.e. Dr. Remi Delaporte-Mathurin? Though it's up to you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah it's fine :)

@RemDelaporteMathurin RemDelaporteMathurin merged commit 61d6792 into main Jul 23, 2024
8 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the maintainers branch July 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of maintainers in docs
2 participants