Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with XDMF export in mode last #796

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This is the fix for #738

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Jul 3, 2024
@RemDelaporteMathurin RemDelaporteMathurin linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (f1f9a71) to head (86d54ce).
Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   99.53%   99.50%   -0.03%     
==========================================
  Files          59       59              
  Lines        2581     2647      +66     
==========================================
+ Hits         2569     2634      +65     
- Misses         12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KulaginVladimir KulaginVladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RemDelaporteMathurin, fix works fine. Just a comment on the test description.

test/system/test_misc.py Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin merged commit b56a3dc into main Jul 3, 2024
5 of 6 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the fix-last-xdmf branch July 3, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] XDMFExport with mode="last"
2 participants