-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: stepsize and Newton Solver #777
Documentation: stepsize and Newton Solver #777
Conversation
.. warning:: | ||
|
||
For a stationary heat transfer problem, a custom Newton solver has to be provided before the simulation initialisation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add another warning saying that this will override the solver parameters given in Settings
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional changes
|
||
The linear solver method can be set with the ``linear_solver`` attribute. The list of available linear solvers can be viewed with: ``print(fenics.list_linear_solver_methods())``. | ||
|
||
.. dropdown:: Linear solver methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, didn't know that 👍
@RemDelaporteMathurin I also included another example for a Concerning the last example, maybe a full simulation case, e.g. Poisson problem or whatever, will be better? Say, I'll add a simple problem with a plot of convergence dynamics similar to this: #673 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 59 59
Lines 2577 2577
=======================================
Hits 2565 2565
Misses 12 12 ☔ View full report in Codecov by Sentry. |
Maybe a tutorial in the workshop is better? |
If the included examples are fine, I can make a new tutorial task for the workshop. |
Proposed changes
Based on #775, this PR updates docs for
Stepsize
and adds some information on the usage of a customNewtonSolver
.Types of changes
What types of changes does your code introduce to FESTIM?
Checklist