Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SALOME meshing guide #776

Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This is an attempt at a simple SALOME to FESTIM tutorial advancing towards #739.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (fb2c99f) to head (09143db).
Report is 40 commits behind head on main.

Current head 09143db differs from pull request most recent head 3af630d

Please upload reports for the commit 3af630d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   99.51%   99.53%   +0.01%     
==========================================
  Files          58       59       +1     
  Lines        2488     2577      +89     
==========================================
+ Hits         2476     2565      +89     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin linked an issue Jun 5, 2024 that may be closed by this pull request
@KulaginVladimir
Copy link
Collaborator

@RemDelaporteMathurin, I followed the guide. In my opinion, it's nice! However, it's a bit hard to read, since the bullet points are just stacked to screenshots, but not really a problem.

Possibly, a 3D example could be a better choice, as it's usually easier to do a simpler case based on a more complex example, rather than otherwise. What do you think?

Moreover, what does the last screenshot show? I expected a mesh representation in ParaView (similar to the mesh in SALOME from the pre-last screenshot of your guide). By default, I get this view in ParaView:
image

@RemDelaporteMathurin
Copy link
Collaborator Author

it's a bit hard to read, since the bullet points are just stacked to screenshots, but not really a problem.

I adapted the size of the images let me know what you think

Moreover, what does the last screenshot show? I expected a mesh representation in ParaView (similar to the mesh in SALOME from the pre-last screenshot of your guide). By default, I get this view in ParaView:

So we discussed about this on the side and it appeared that this is just from using the wrong XDMF reader in Paraview.
Maybe similar to this PR we need a small Paraview tutorial or at least write somewhere which reader users should use.

@RemDelaporteMathurin
Copy link
Collaborator Author

@KulaginVladimir @jhdark I added the CAD based workflow, let me know what you think

@RemDelaporteMathurin RemDelaporteMathurin merged commit f1f9a71 into festim-dev:main Jun 13, 2024
3 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the meshing-guide branch June 13, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guide to meshing
2 participants