-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SALOME meshing guide #776
SALOME meshing guide #776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 99.51% 99.53% +0.01%
==========================================
Files 58 59 +1
Lines 2488 2577 +89
==========================================
+ Hits 2476 2565 +89
Misses 12 12 ☔ View full report in Codecov by Sentry. |
@RemDelaporteMathurin, I followed the guide. In my opinion, it's nice! However, it's a bit hard to read, since the bullet points are just stacked to screenshots, but not really a problem. Possibly, a 3D example could be a better choice, as it's usually easier to do a simpler case based on a more complex example, rather than otherwise. What do you think? Moreover, what does the last screenshot show? I expected a mesh representation in ParaView (similar to the mesh in SALOME from the pre-last screenshot of your guide). By default, I get this view in ParaView: |
I adapted the size of the images let me know what you think
So we discussed about this on the side and it appeared that this is just from using the wrong XDMF reader in Paraview. |
@KulaginVladimir @jhdark I added the CAD based workflow, let me know what you think |
Proposed changes
This is an attempt at a simple SALOME to FESTIM tutorial advancing towards #739.
Types of changes
What types of changes does your code introduce to FESTIM?