Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map of institutions in documentation #761

Merged
merged 14 commits into from
Apr 22, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR adds an interactive map of institutions using FESTIM in the documentation, alongside with script to reproduce it

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (fdfcb17) to head (a718eb4).
Report is 34 commits behind head on main.

❗ Current head a718eb4 differs from pull request most recent head 07350e9. Consider uploading reports for the commit 07350e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   99.48%   99.51%   +0.02%     
==========================================
  Files          58       58              
  Lines        2350     2468     +118     
==========================================
+ Hits         2338     2456     +118     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KulaginVladimir
Copy link
Collaborator

@RemDelaporteMathurin
Looks cool!

Just a couple of questions.

Should it be above the contents? As an example, the list of institutions/organisations can be on a dedicated page, but not necessary.

What are these blue areas? Polygons which vertices are the institutions/organisations?
image

How did you place the institutions/organisations? For example, MEPhI is rather here :)
image

@RemDelaporteMathurin
Copy link
Collaborator Author

Should it be above the contents? As an example, the list of institutions/organisations can be on a dedicated page, but not necessary.

I kind of like the idea that it would be on the front page but we can also have a dedicated page. One day we may have also a list of publications associated with each institution? who knows!

What are these blue areas? Polygons which vertices are the institutions/organisations?

I think that is yes

How did you place the institutions/organisations? For example, MEPhI is rather here :)

I asked ChatGPT!!! thanks for pointing this out I'll correct it

@RemDelaporteMathurin RemDelaporteMathurin merged commit 24420e6 into festim-dev:main Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants