-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robin boundary conditions for ParticleFlux #752
Robin boundary conditions for ParticleFlux #752
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #752 +/- ##
===========================================
- Coverage 98.42% 98.31% -0.11%
===========================================
Files 28 28
Lines 1519 1540 +21
===========================================
+ Hits 1495 1514 +19
- Misses 24 26 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment on the create_value_fenics,, otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding some extra logic in here to make sure 1. A species object is given 2. the arguments are unique and users don't give t, x or T 3. The species given is mobile.
Not sure if this is overkill or not
I gave a partial example of this in #746
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would hold this off for now as it's applicable to all paticle fluxes
Proposed changes
This closes #749.
Uage:
Merge #750 before this.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist