-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset derived quantity objects data and t at the beginning of a simulation #733
Reset derived quantity objects data and t at the beginning of a simulation #733
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #733 +/- ##
========================================
Coverage 97.76% 97.76%
========================================
Files 44 44
Lines 2099 2102 +3
========================================
+ Hits 2052 2055 +3
Misses 47 47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial round of comments, the fix obviously works fine, but it's not the right place for it.
my_export = F.SurfaceFlux( | ||
field=H, | ||
surface=surf, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you parametrise this test to also check for other derived quantities (eg. TotalVolume)
Hey @Allentro what is the status of this? |
Hi Remi, sorry this has slipped my list. I'll get this complete tomorrow! |
Hi @Allentro! Do you want someone else to pick up this PR? |
Hi Remi, This slipped my inbox.. I was just scrolling through my mentions and saw this. I'm happy to work on this tomorrow evening. Sorry for the delay on this. |
Proposed changes
I have implemented a fix to reset export.t and export.data at the beginning of a simulation, accompanied by a respective test. This PR resolves #728
Types of changes
Checklist