Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring of tests #726

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

KulaginVladimir
Copy link
Collaborator

Proposed changes

This PR introduces some modification to tests. Linked to #530.

Some information was added to the descripton of tests and several specific tests were parametrised.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Since there are a lot of modifications at the moment, I decided to show them in order to get a proper understanding of changes appropriateness.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (dfec377) to head (682a902).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   99.48%   99.49%           
=======================================
  Files          58       58           
  Lines        2350     2358    +8     
=======================================
+ Hits         2338     2346    +8     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KulaginVladimir KulaginVladimir marked this pull request as ready for review March 29, 2024 20:32
@RemDelaporteMathurin RemDelaporteMathurin self-requested a review March 29, 2024 21:32
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KulaginVladimir we needed this clean up!

@RemDelaporteMathurin RemDelaporteMathurin merged commit af31da2 into festim-dev:main Apr 1, 2024
5 checks passed
@KulaginVladimir KulaginVladimir deleted the Tests branch June 6, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants