-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max_stepsize
attribute for festim.Stepsize
#698
max_stepsize
attribute for festim.Stepsize
#698
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 58 58
Lines 2280 2284 +4
=======================================
+ Hits 2268 2272 +4
Misses 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KulaginVladimir thanks for this!
I made a few comments + refactoring idea. Tell me what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment for code readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @KulaginVladimir
As usual, I'll leave the PR open a little while longer to give everyone the chance to jump in
Proposed changes
As discussed in #507, this PR introduces
max_stepsize
attribute forfestim.Stepsize
instead oft_stop
andstepsize_stop_max
. The old parameters are left unchanged, but aDeprecationWarning
is added. With this change, the basic usage now becomes:Types of changes
What types of changes does your code introduce to FESTIM?
Checklist