-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F.Materials -> subclass of list #694
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 58 58
Lines 2188 2188
=======================================
Hits 2165 2165
Misses 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KulaginVladimir this is exactly what we need to do. I hope you see why it increases the readibility of the code base, and is just more logical overall.
We'd have to do the same for other classes.
A few small comments on my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Apologies for the back and forth discussion on equlity!
We should do the same for other classes too!
Proposed changes
This PR modifies
F.Materials
to be a subclass oflist
following #494.@RemDelaporteMathurin, @jhdark, please, let me know what do you think and if this is what is needed.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist