Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in test_unused_thermal_cond due to pytest update #691

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

KulaginVladimir
Copy link
Collaborator

Proposed changes

Due to new release of pytest (v8.0.0), test_unused_thermal_cond fails. The failure appears since pytest.warns(None) is depricated (since pytest v7.0.0rc1) and all PytestRemovedIn8Warning deprecation warnings are now errors by default (since pytest v8.0.0rc1). This PR modifies the test according to suggestions.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ada717a) 98.94% compared to head (41a24bb) 98.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          58       58           
  Lines        2181     2181           
=======================================
  Hits         2158     2158           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit e1554d3 into festim-dev:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants