-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about derived quantities in non cartesian #688
Merged
RemDelaporteMathurin
merged 9 commits into
festim-dev:main
from
RemDelaporteMathurin:warn-about-SurfaceFlux-in-non-cartesian
Feb 27, 2024
Merged
Warn about derived quantities in non cartesian #688
RemDelaporteMathurin
merged 9 commits into
festim-dev:main
from
RemDelaporteMathurin:warn-about-SurfaceFlux-in-non-cartesian
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 58 58
Lines 2280 2286 +6
=======================================
+ Hits 2268 2274 +6
Misses 12 12 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
changed the title
Warn about surface flux in non cartesian
Warn about derived quantities in non cartesian
Jan 23, 2024
jhdark
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
RemDelaporteMathurin
deleted the
warn-about-SurfaceFlux-in-non-cartesian
branch
February 27, 2024 13:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a warning when users employ
SurfaceFlux
with a non-cartesian mesh (eg. an axisymmetric 2D mesh).Indeed, the flux (example here for particles) expression is
where$n$ is the normal vector and
In cartesian coordinates, the element$dS$ is $dS = dx \ dy $ , assuming it is $y$ independent $dS = y \ dx$ .
And this is the default behaviour in fenics.
However in cylindrical$(r, \theta, z)$ , the surface element is $dS = r \ dr \ d\theta$ , assuming it is axisymmetric ($\theta$ independent), then $dS =\theta \ r \ dr$
The flux becomes:
which is NOT the default behaviour of
SurfaceFlux
.While we wait for a native support of fluxes in cylindrical coordinates to be implemented, users should at least be warn that this may be an issue.
The same goes for
TotalVolume
,AverageVolume
, etc.Thanks @WeaverC20 for helping spotting this
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist