Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #681

Merged
merged 21 commits into from
Jan 19, 2024
Merged

Improve docs #681

merged 21 commits into from
Jan 19, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This PR has been a long time coming... Flushing out the User Guide of the documentation.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c6ca17) 98.93% compared to head (d64d5e1) 98.99%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   98.93%   98.99%   +0.06%     
==========================================
  Files          57       58       +1     
  Lines        2154     2290     +136     
==========================================
+ Hits         2131     2267     +136     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin marked this pull request as ready for review January 16, 2024 22:41
@KulaginVladimir
Copy link
Collaborator

Looks nice. Several minor suggestions. @RemDelaporteMathurin, what do you think of adding some information about:

  • The Soret coefficient in Materials
  • The stepsize settings (adaptive stepsize)
  • An example of the PointValue usage in PP

@RemDelaporteMathurin
Copy link
Collaborator Author

Looks nice. Several minor suggestions. @RemDelaporteMathurin, what do you think of adding some information about:

  • The Soret coefficient in Materials
  • The stepsize settings (adaptive stepsize)
  • An example of the PointValue usage in PP

Done! let me know what you think.

@KulaginVladimir
Copy link
Collaborator

Perfect! Though I didn't find an example of the InitialCondition usage (nowhere). Maybe, it's also worth adding. As an option, the Boundary conditions section can be extented to Initial & Boundary conditions. Nonetherless, the current version is OK to me.

@RemDelaporteMathurin
Copy link
Collaborator Author

@KulaginVladimir good shout! I added the initial conditions

@RemDelaporteMathurin
Copy link
Collaborator Author

@KulaginVladimir I split ICs and BCs and added the initial conditions from XDMF files to the docs. Once it's compiled you should see it here

@KulaginVladimir
Copy link
Collaborator

I think it is a nice guide. Would have been really helpful when I started using FESTIM 😄

@RemDelaporteMathurin
Copy link
Collaborator Author

RemDelaporteMathurin commented Jan 18, 2024

I think it is a nice guide. Would have been really helpful when I started using FESTIM 😄

Apologies for this... New users have a complete guide now! Thanks for your review!

I'll let @jhdark have a look too and once it's approved then I'll merge it.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor typos and grammar from me, although if I ever find a few days free I could go through all the docs more thoroughly. Otherwise thanks a lot for doing this! Its tedious work but hugely beneficial to new users!

docs/source/devguide/index.rst Outdated Show resolved Hide resolved
docs/source/devguide/index.rst Outdated Show resolved Hide resolved
docs/source/devguide/index.rst Outdated Show resolved Hide resolved
docs/source/devguide/index.rst Show resolved Hide resolved
docs/source/userguide/beginners_guide.rst Outdated Show resolved Hide resolved
docs/source/userguide/troubleshooting.rst Outdated Show resolved Hide resolved
docs/source/userguide/troubleshooting.rst Outdated Show resolved Hide resolved
docs/source/userguide/troubleshooting.rst Outdated Show resolved Hide resolved
docs/source/userguide/troubleshooting.rst Outdated Show resolved Hide resolved
docs/source/userguide/troubleshooting.rst Outdated Show resolved Hide resolved
@RemDelaporteMathurin
Copy link
Collaborator Author

@jhdark thanks for your feedback. I pushed the suggested changes, we are in no rush to merge this so if you need more time no worries.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RemDelaporteMathurin RemDelaporteMathurin merged commit 4500c9c into main Jan 19, 2024
6 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the improve-docs branch January 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants