-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs #681
Improve docs #681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 98.93% 98.99% +0.06%
==========================================
Files 57 58 +1
Lines 2154 2290 +136
==========================================
+ Hits 2131 2267 +136
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Looks nice. Several minor suggestions. @RemDelaporteMathurin, what do you think of adding some information about:
|
Done! let me know what you think. |
Perfect! Though I didn't find an example of the |
@KulaginVladimir good shout! I added the initial conditions |
@KulaginVladimir I split ICs and BCs and added the initial conditions from XDMF files to the docs. Once it's compiled you should see it here |
I think it is a nice guide. Would have been really helpful when I started using FESTIM 😄 |
Apologies for this... New users have a complete guide now! Thanks for your review! I'll let @jhdark have a look too and once it's approved then I'll merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor typos and grammar from me, although if I ever find a few days free I could go through all the docs more thoroughly. Otherwise thanks a lot for doing this! Its tedious work but hugely beneficial to new users!
Co-authored-by: James Dark <[email protected]>
@jhdark thanks for your feedback. I pushed the suggested changes, we are in no rush to merge this so if you need more time no worries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Proposed changes
This PR has been a long time coming... Flushing out the User Guide of the documentation.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist