Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOC in Theory #670

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Dec 13, 2023

Proposed changes

This PR fixes the bug in the ToC introduced in #664 by updating the version of sphinx-book-theme and sphinx

image

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

@RemDelaporteMathurin RemDelaporteMathurin added bug Something isn't working Documentation labels Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8a2063) 98.91% compared to head (2ad9b4a) 98.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          57       57           
  Lines        2128     2128           
=======================================
  Hits         2105     2105           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RemDelaporteMathurin RemDelaporteMathurin merged commit 7f5ffef into festim-dev:main Dec 13, 2023
5 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the fix-toc branch December 13, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants