InitialCondition for HeatTransferProblem #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you very much @KulaginVladimir again for this contribution!
Just a comment for more consistency across the code base.
Also re-running the test cause apparently the upload to Codecov failed...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 57 57
Lines 2124 2128 +4
=======================================
+ Hits 2101 2105 +4
Misses 23 23 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Dec 6, 2023
KulaginVladimir
commented
Dec 6, 2023
RemDelaporteMathurin
requested changes
Dec 7, 2023
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
RemDelaporteMathurin
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Thanks @KulaginVladimir ! This had been missing for a long long time! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
According to #659, this PR attempts to enhance the functionality of initial condition for
HeatTransferProblem. Additionally, the tests were updated to follow new changes.Types of changes
What types of changes does your code introduce to FESTIM?
Checklist