-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshFromVertices in parallel #634
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 56 56
Lines 2096 2098 +2
=======================================
+ Hits 2073 2075 +2
Misses 23 23
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KulaginVladimir thanks for this fix! 🎉
@jhdark I tested it locally and confirm the MWE given in issue #497 now passes with this fix!
I just have a small comment to add for future reference but apart from that very happy to merge.
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhdark feel free to merge this one today
Proposed changes
This PR attempts to fix #497
I added
fenics.MeshPartitioning.build_distributed_mesh()
after mesh creation withfenics.MeshEditor
onrank==0
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist