Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshFromVertices in parallel #634

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

KulaginVladimir
Copy link
Collaborator

Proposed changes

This PR attempts to fix #497

I added fenics.MeshPartitioning.build_distributed_mesh() after mesh creation with fenics.MeshEditor on rank==0

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@KulaginVladimir KulaginVladimir changed the title MeshFromVerticles in parallel MeshFromVertices in parallel Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f05de7) 98.90% compared to head (f088aae) 98.90%.
Report is 27 commits behind head on main.

❗ Current head f088aae differs from pull request most recent head 88e2597. Consider uploading reports for the commit 88e2597 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          56       56           
  Lines        2096     2098    +2     
=======================================
+ Hits         2073     2075    +2     
  Misses         23       23           
Files Coverage Δ
festim/meshing/mesh_from_vertices.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Nov 4, 2023
@RemDelaporteMathurin RemDelaporteMathurin self-assigned this Nov 4, 2023
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KulaginVladimir thanks for this fix! 🎉

@jhdark I tested it locally and confirm the MWE given in issue #497 now passes with this fix!
I just have a small comment to add for future reference but apart from that very happy to merge.

festim/meshing/mesh_from_vertices.py Show resolved Hide resolved
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhdark feel free to merge this one today

@jhdark jhdark merged commit 79e7bfd into festim-dev:main Nov 6, 2023
2 checks passed
@KulaginVladimir KulaginVladimir deleted the MeshEditor_parallel branch November 8, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] vertices mesh crashes in parallel
3 participants