-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release #501
Patch release #501
Conversation
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
…rteMathurin/FESTIM into tempfromxdmf-transient
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
TemperatureFromXDMF with transient h transport cases
Yeah sure, but we calling it 0.10.1 or 0.11, not sure if its enough for 0.11 |
That would be a patch (only bugfixes) so 0.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this, although not sure if we should add more detail to the doc strings on the update function
Nah it's grand, we reviewed these changes in #500 |
Proposed changes
@jhdark do you mind if we merge this into main and make a patch release?
Types of changes
What types of changes does your code introduce to FESTIM?