Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release #501

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Patch release #501

merged 8 commits into from
Jul 27, 2022

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Jul 27, 2022

Proposed changes

@jhdark do you mind if we merge this into main and make a patch release?

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

@jhdark
Copy link
Collaborator

jhdark commented Jul 27, 2022

Yeah sure, but we calling it 0.10.1 or 0.11, not sure if its enough for 0.11

@RemDelaporteMathurin
Copy link
Collaborator Author

Yeah sure, but we calling it 0.10.1 or 0.11, not sure if its enough for 0.11

That would be a patch (only bugfixes) so 0.10.1

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, although not sure if we should add more detail to the doc strings on the update function

@RemDelaporteMathurin
Copy link
Collaborator Author

Nah it's grand, we reviewed these changes in #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TemperatureFromXDMF class not working in transient h transport
2 participants