Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added __version__ attribute #491

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Jun 13, 2022

Proposed changes

This PR fixes #489 by adding a version attribute to FESTIM

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #491 (8adaf12) into dev (67b34e0) will decrease coverage by 0.09%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##              dev     #491      +/-   ##
==========================================
- Coverage   98.89%   98.80%   -0.10%     
==========================================
  Files          54       54              
  Lines        1994     2005      +11     
==========================================
+ Hits         1972     1981       +9     
- Misses         22       24       +2     
Impacted Files Coverage Δ
FESTIM/__init__.py 97.10% <81.81%> (-2.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b34e0...8adaf12. Read the comment docs.

@RemDelaporteMathurin
Copy link
Collaborator Author

can't do much about the coverage I'm afraid

@RemDelaporteMathurin RemDelaporteMathurin merged commit 3fb6cd8 into dev Jun 13, 2022
@RemDelaporteMathurin RemDelaporteMathurin linked an issue Jun 13, 2022 that may be closed by this pull request
@RemDelaporteMathurin RemDelaporteMathurin deleted the RemDelaporteMathurin-patch-1 branch July 27, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__version__ attribute
1 participant