Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise Stepsize.value in Simulation.initialise() #486

Merged
merged 6 commits into from
May 17, 2022

Conversation

RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented May 17, 2022

Proposed changes

Fixes #485 by initialising re-initialising the stepsize value when calling Simulation.initialise

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@RemDelaporteMathurin RemDelaporteMathurin linked an issue May 17, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #486 (dbb3707) into dev (035bcd5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #486   +/-   ##
=======================================
  Coverage   98.88%   98.89%           
=======================================
  Files          53       53           
  Lines        1976     1982    +6     
=======================================
+ Hits         1954     1960    +6     
  Misses         22       22           
Impacted Files Coverage Δ
FESTIM/generic_simulation.py 100.00% <100.00%> (ø)
FESTIM/stepsize.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035bcd5...dbb3707. Read the comment docs.

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@RemDelaporteMathurin RemDelaporteMathurin merged commit 67b34e0 into dev May 17, 2022
@RemDelaporteMathurin RemDelaporteMathurin deleted the fix_dt_value_null branch July 27, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several transient simulations in a row
2 participants